Updating Bigtable and Datastore autogenerate makefiles.#2452
Merged
dhermes merged 1 commit intogoogleapis:masterfrom Sep 27, 2016
Merged
Updating Bigtable and Datastore autogenerate makefiles.#2452dhermes merged 1 commit intogoogleapis:masterfrom
dhermes merged 1 commit intogoogleapis:masterfrom
Conversation
In the process, also updating a hardcoded path in make_datastore_grpc. Also, re-running `make generate` in each of these introduced small changes to the autogenerated bigtable modules.
googlebot
added
the
cla: yes
32 tasks
daspecster
approved these changes
Sep 27, 2016
Contributor
daspecster
left a comment
daspecster
left a comment
There was a problem hiding this comment.
Looks like a straight forward change. LGTM
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
Updating Bigtable and Datastore autogenerate makefiles.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process, also updating a hardcoded path in make_datastore_grpc.
Also, re-running
make generatein each of these introduced small changes to the autogenerated bigtable modules.(This PR needed due to subpackages moving into their own self-contained folders.)